infra: actions: add check-format job

Doing this so I can change this site wide in the future without anything breaking

.dir-locals.el

@@ -3,12 +3,12 @@
                (rust-cargo-default-arguments . "-r")
                (eglot-workspace-configuration . (:rust-analyzer
                                                  (:check
-                                                  (:overrideCommand ["./rust-analyzer.sh"]))))
+                                                  (:overrideCommand ["ninja" "clippy-json" "-C" "build"]))))
                (eval . (add-to-list 'eglot-server-programs
                                     '((rust-ts-mode rust-mode) .
                                       ("rust-analyzer" :initializationOptions
                                        (:check
-                                        (:overrideCommand ["./rust-analyzer.sh"]))))))
+                                        (:overrideCommand ["ninja" "clippy-json" "-C" "build"]))))))
                (eval . (eglot-ensure))
                (eval . (company-mode 1))
                (eval . (add-hook 'before-save-hook 'fmt-current-buffer nil t))

check_commands.txt

@@ -2,4 +2,4 @@
 ninja rustfmt -C build
 ninja rustdoc -C build
 ninja clippy -C build
-ninja test -C build
+meson test -C build

fuzz/atom/parser/fuzz.rs

@@ -1,4 +1,3 @@
-#![deny(unused_imports)]
 #![allow(clippy::missing_safety_doc)]
 
 use core::slice;

fuzz/atom/parser/meson.build

@@ -1,12 +1,12 @@
 gencorpus = executable(
-    'atom_parser_gencorpus',
+    'gencorpus',
     'gencorpus.rs',
     dependencies: [mon],
     link_with: [gentoo_utils],
 )
 
 corpus = custom_target(
-    'atom_parser_corpus',
+    'corpus',
     output: 'corpus',
     command: [gencorpus, 'corpus'],
 )

fuzz/atom/vercmp/fuzz.rs

@@ -1,8 +1,9 @@
-#![deny(unused_imports)]
-
 use core::slice;
-use gentoo_utils::{Parseable, atom::Version};
-use mon::{Parser, input::InputIter};
+use gentoo_utils::{
+    Parseable,
+    atom::{Atom, Version},
+};
+use mon::{Parser, ParserFinishedError, input::InputIter};
 use std::{
     cmp::Ordering,
     io::{BufRead, BufReader, Write},

fuzz/atom/vercmp/meson.build

@@ -1,12 +1,12 @@
 gencorpus = executable(
-    'atom_vercmp_gencorpus',
+    'gencorpus',
     'gencorpus.rs',
     dependencies: [mon],
     link_with: [gentoo_utils],
 )
 
 corpus = custom_target(
-    'atom_vercmp_corpus',
+    'corpus',
     output: 'corpus',
     command: [gencorpus, 'corpus'],
 )

rust-analyzer.sh

@@ -1,12 +0,0 @@
-#!/bin/bash
-
-# this script is a temporary workaround for not having a proper clippy-json target
-
-source /etc/profile
-
-cd build || exit $?
-
-# compile as far as we can
-ninja
-
-ninja clippy-json

rust-project.json

@@ -1 +0,0 @@
-build/rust-project.json

src/atom/mod.rs

@@ -646,6 +646,14 @@ mod test {
 
     use crate::Parseable;
 
+    macro_rules! assert_eq_display {
+        ($a:expr, $b:expr) => {
+            if $a != $b {
+                panic!("{} != {}", $a, $b);
+            }
+        };
+    }
+
     macro_rules! assert_cmp_display {
         ($a:expr, $b:expr, $ordering:expr) => {
             if $a.cmp(&$b) != $ordering {
@@ -762,7 +770,6 @@ mod test {
             .parse_finished(InputIter::new("1.2.0a_alpha1_beta2-r1-8"))
             .unwrap();
 
-        #[allow(clippy::single_element_loop)]
         for (version_str, expected) in [("1.2.0", Ordering::Greater)] {
             let version = Version::parser()
                 .parse_finished(InputIter::new(version_str))