From 673657258a61794b2eff45a6f1c655b432ae5e4e Mon Sep 17 00:00:00 2001 From: John Turner Date: Sun, 14 Dec 2025 04:02:09 +0000 Subject: [PATCH 1/6] grep for todo! and dbg! in check_commands and in CI --- .gitea/workflows/gentoo-utils.yml | 14 ++++++++++++++ check_commands.txt | 1 + 2 files changed, 15 insertions(+) diff --git a/.gitea/workflows/gentoo-utils.yml b/.gitea/workflows/gentoo-utils.yml index 683524c..5ec33a6 100644 --- a/.gitea/workflows/gentoo-utils.yml +++ b/.gitea/workflows/gentoo-utils.yml @@ -153,3 +153,17 @@ jobs: run: | meson setup -Ddocs=enabled docs ninja rustdoc -C docs + + grep: + runs-on: brutalisk + needs: [build-oci-image] + container: + image: ${{ vars.REGISTRY_URL }}/${{ gitea.repository }}:${{ needs.build-oci-image.outputs.image_tag }} + steps: + - name: Checkout repo + uses: actions/checkout@v5 + + - name: grep for patterns + run: | + egrep 'todo!|dbg!' -qvr src + diff --git a/check_commands.txt b/check_commands.txt index 671a1a2..e6677ed 100644 --- a/check_commands.txt +++ b/check_commands.txt @@ -3,3 +3,4 @@ ninja rustfmt -C build ninja rustdoc -C build ninja clippy -C build ninja test -C build +egrep 'todo!|dbg!' -qvr src From 5235e7d5a52d2d42b17e977acead615d835a4777 Mon Sep 17 00:00:00 2001 From: John Turner Date: Sun, 14 Dec 2025 04:28:52 +0000 Subject: [PATCH 2/6] fixup --- .gitea/workflows/gentoo-utils.yml | 6 +++++- check_commands.txt | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.gitea/workflows/gentoo-utils.yml b/.gitea/workflows/gentoo-utils.yml index 5ec33a6..53666fb 100644 --- a/.gitea/workflows/gentoo-utils.yml +++ b/.gitea/workflows/gentoo-utils.yml @@ -165,5 +165,9 @@ jobs: - name: grep for patterns run: | - egrep 'todo!|dbg!' -qvr src + if git grep -e 'dbg!' -- '*.rs'; then + false + else + true + fi diff --git a/check_commands.txt b/check_commands.txt index e6677ed..2bb8a74 100644 --- a/check_commands.txt +++ b/check_commands.txt @@ -3,4 +3,4 @@ ninja rustfmt -C build ninja rustdoc -C build ninja clippy -C build ninja test -C build -egrep 'todo!|dbg!' -qvr src +if git grep -e 'dbg!' -- '*.rs'; then false; else true; fi From 8f3b07f6c95e9b32b3a53cc9a8a6f6ffecf2a6da Mon Sep 17 00:00:00 2001 From: John Turner Date: Sun, 14 Dec 2025 04:30:04 +0000 Subject: [PATCH 3/6] fixup --- .gitea/workflows/gentoo-utils.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitea/workflows/gentoo-utils.yml b/.gitea/workflows/gentoo-utils.yml index 53666fb..e757468 100644 --- a/.gitea/workflows/gentoo-utils.yml +++ b/.gitea/workflows/gentoo-utils.yml @@ -165,7 +165,7 @@ jobs: - name: grep for patterns run: | - if git grep -e 'dbg!' -- '*.rs'; then + if git grep -e 'dbg!|todo!' -- '*.rs'; then false else true From 87d02f1b3d19ac91029deac60d07565445708e7f Mon Sep 17 00:00:00 2001 From: John Turner Date: Sun, 14 Dec 2025 04:34:28 +0000 Subject: [PATCH 4/6] fixup --- .gitea/workflows/gentoo-utils.yml | 7 +------ check_commands.txt | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/.gitea/workflows/gentoo-utils.yml b/.gitea/workflows/gentoo-utils.yml index e757468..e3a07c9 100644 --- a/.gitea/workflows/gentoo-utils.yml +++ b/.gitea/workflows/gentoo-utils.yml @@ -165,9 +165,4 @@ jobs: - name: grep for patterns run: | - if git grep -e 'dbg!|todo!' -- '*.rs'; then - false - else - true - fi - + git grep 'todo!|dbg!' -- '*.rs' && exit 1 diff --git a/check_commands.txt b/check_commands.txt index 2bb8a74..cdf552d 100644 --- a/check_commands.txt +++ b/check_commands.txt @@ -3,4 +3,4 @@ ninja rustfmt -C build ninja rustdoc -C build ninja clippy -C build ninja test -C build -if git grep -e 'dbg!' -- '*.rs'; then false; else true; fi +git grep 'todo!|dbg!' -- '*.rs' && exit 1 From 059678712d4ee8d18f7e61994ba2dc6a7934e957 Mon Sep 17 00:00:00 2001 From: John Turner Date: Sun, 14 Dec 2025 04:36:15 +0000 Subject: [PATCH 5/6] fill in todo! in match arm --- src/repo/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/repo/mod.rs b/src/repo/mod.rs index 47ed28b..eb68839 100644 --- a/src/repo/mod.rs +++ b/src/repo/mod.rs @@ -102,7 +102,7 @@ impl Iterator for Ebuilds { Ok(ebuild) => break Some(Ok(ebuild)), Err(e) => break Some(Err(e)), }, - _ => todo!(), + Err(e) => break Some(Err(Error::ReadDir(self.0.clone(), e))), } } } From 402e62092486a12f5bb1154b3c97ab30aa7c5dab Mon Sep 17 00:00:00 2001 From: John Turner Date: Sun, 14 Dec 2025 04:38:07 +0000 Subject: [PATCH 6/6] fixup --- .gitea/workflows/gentoo-utils.yml | 2 +- check_commands.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitea/workflows/gentoo-utils.yml b/.gitea/workflows/gentoo-utils.yml index e3a07c9..03c2117 100644 --- a/.gitea/workflows/gentoo-utils.yml +++ b/.gitea/workflows/gentoo-utils.yml @@ -165,4 +165,4 @@ jobs: - name: grep for patterns run: | - git grep 'todo!|dbg!' -- '*.rs' && exit 1 + git grep 'todo!|dbg!' -- '*.rs' && exit 1 || exit 0 diff --git a/check_commands.txt b/check_commands.txt index cdf552d..664a7ac 100644 --- a/check_commands.txt +++ b/check_commands.txt @@ -3,4 +3,4 @@ ninja rustfmt -C build ninja rustdoc -C build ninja clippy -C build ninja test -C build -git grep 'todo!|dbg!' -- '*.rs' && exit 1 +git grep 'todo!|dbg!' -- '*.rs' && exit 1 || exit 0